-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Closed
Labels
Description
gh-ost currently does not pass a timeout or context to the HTTP client in go/logic/throttler.go
The lack of a timeout can theoretically cause the ticker-loop in .collectThrottleHTTPStatus() to block for a response indefinitely
Passing a context.Context to the net/http client will allow slow calls to an HTTP throttler service (eg: github/freno) to timeout instead of block the loop. A PR is on the way 👍
Reactions are currently unavailable