Hermetic Builds 🔒 #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements hermetic builds to ensure reproducible and dependency-isolated builds. The changes establish a vendor-only build system that prevents network access during builds and ensures all dependencies are sourced locally.
- Introduces hermetic build environment with vendor-only dependency resolution
- Adds comprehensive build scripts for consistent development workflow
- Updates version handling to properly support both ldflags and VCS fallback mechanisms
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| script/env | New shared environment setup with hermetic Go proxy settings |
| script/bootstrap | New hermetic dependency verification script |
| script/build | New build script with version embedding via ldflags |
| script/update | New dependency update script with hermetic environment controls |
| script/test | Updated to use vendor mode and shared environment |
| script/lint | Updated to use vendor mode and shared environment |
| script/release | Updated bash shebang and error handling |
| internal/version/version.go | Refactored to support ldflags precedence over VCS info |
| internal/version/version_test.go | Updated tests for new version handling logic |
| .github/workflows/*.yml | Added bootstrap step to all CI workflows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.