fix: port-safe GHEC detection in deriveAPIFromServerURL#2484
Merged
lpcox merged 2 commits intofix/ghec-tenant-supportfrom Mar 24, 2026
Merged
fix: port-safe GHEC detection in deriveAPIFromServerURL#2484lpcox merged 2 commits intofix/ghec-tenant-supportfrom
lpcox merged 2 commits intofix/ghec-tenant-supportfrom
Conversation
…EC detection Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw-mcpg/sessions/9a1660e8-6d08-4073-af81-1733316890aa
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add GHEC tenant support for proxy and guard URL parsing
fix: port-safe GHEC detection in deriveAPIFromServerURL
Mar 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the proxy’s GitHub API URL derivation logic to correctly handle GITHUB_SERVER_URL values that include an explicit port for GHEC tenants (*.ghe.com), and adds a regression test for this case.
Changes:
- Fix
deriveAPIFromServerURL()to perform domain/suffix checks againsturl.URL.Hostname()(so ports don’t break matching). - Preserve the original port when deriving
copilot-api.<tenant>.ghe.comURLs. - Add a unit test covering a GHEC tenant URL with a port.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/proxy/proxy.go | Adjusts URL parsing to use Hostname() for matching and re-adds port for GHEC derivation. |
| internal/proxy/proxy_test.go | Adds a test case validating correct derivation for GHEC tenant URLs with a port. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
url.Parsestores host+port together inparsed.Host(e.g.mycompany.ghe.com:8443), sostrings.HasSuffix(host, ".ghe.com")silently fails when a non-standard port is present, causing GHEC URLs to fall through to GHES/api/v3derivation.Changes
deriveAPIFromServerURL: switch fromparsed.Hosttoparsed.Hostname()for.ghe.com/github.comchecks; re-append port viaparsed.Port()when formatting the GHECcopilot-api.*URLGHEC tenant with portcase (https://mycompany.ghe.com:8443→https://copilot-api.mycompany.ghe.com:8443)📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.