refactor: eliminate duplicate code patterns in internal/difc package#1916
Merged
refactor: eliminate duplicate code patterns in internal/difc package#1916
Conversation
Copilot created this pull request from a session on behalf of
lpcox
March 14, 2026 23:30
View session
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all three duplicate code patterns identified in the DIFC package analysis.
Changes
1. Agent Tag Add/Drop Operations (
agent.go) — Closes #1720Extracted
modifyTagprivate helper to consolidate the lock/log/mutate pattern shared byAddSecrecyTag,AddIntegrityTag, andDropIntegrityTag. The three methods now delegate to this single helper, eliminating ~15 lines of duplication and ensuring the locking and logging patterns stay in sync.2. DIFC Label CheckFlow Implementations (
labels.go) — Closes #1721Extracted
checkFlowHelperprivate helper to consolidate the nil-guard, doubleRLock, wildcard handling, and tag-subset-check pattern shared bySecrecyLabel.CheckFlowandIntegrityLabel.CheckFlow. The only meaningful difference between the two — direction of the subset check — is parameterised via acheckSubset boolargument.3. EvaluationResult Default Initialization (
evaluator.go) — Closes #1722Extracted
newEmptyEvaluationResultfactory to centralise defaultEvaluationResultconstruction (AccessAllow + empty tag slices) used inEvaluate,evaluateRead, andevaluateWrite. Any future change to EvaluationResult defaults now has a single authoritative location.Closes #1719
Closes #1720
Closes #1721
Closes #1722