-
Notifications
You must be signed in to change notification settings - Fork 18
test: add --env-all integration tests #1042
Copy link
Copy link
Closed
Labels
Description
Parent Issue
Part of #1039
Problem
The `--env-all` flag is the primary production mode — used by `gh-aw`'s `BuildAWFArgs()` to pass all GitHub Actions environment variables into the container. The `environment-variables.test.ts` file header mentions it, but no test uses `envAll: true`.
Acceptance Criteria
- Add `envAll` option to `AwfRunner` in `tests/fixtures/awf-runner.ts` (maps to `--env-all` CLI flag)
- Add integration tests in `tests/integration/environment-variables.test.ts` covering:
- `--env-all` passes host environment variables into the container
- Proxy env vars (`HTTP_PROXY`, `HTTPS_PROXY`) are correctly set inside the container
- `JAVA_TOOL_OPTIONS` is set with JVM proxy properties
- Sensitive tokens (if set) are still subject to token-unsetting behavior
- Verify `--env-all` interacts correctly with `-e` (explicit env vars)
References
- `src/cli.ts` line 699: `--env-all` flag definition
- `src/docker-manager.ts`: How env vars are passed to containers
- `tests/integration/environment-variables.test.ts`: Existing env var tests to extend
Closes #1039 (when combined with other sub-issues)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Fields
Give feedbackNo fields configured for issues without a type.