Fix template conditional expressions creating invalid YAML in heredocs#9289
Merged
Fix template conditional expressions creating invalid YAML in heredocs#9289
Conversation
Move wrapExpressionsInTemplateConditionals before expression extraction
to ensure that GitHub Actions expressions created by wrapping {{#if }}
conditionals are also extracted and replaced with environment variable
placeholders. This prevents invalid YAML syntax in compiled workflows.
Before: {{#if ${{ github.event.issue.number }} }}
After: {{#if __GH_AW_GITHUB_EVENT_ISSUE_NUMBER__ }}
Updated tests to validate correct placeholder replacement behavior.
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix invalid expression in YAML rendered from heredoc
Fix template conditional expressions creating invalid YAML in heredocs
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template conditionals like
{{#if github.event.issue.number}}were being wrapped with${{ }}after expression extraction, creating invalid YAML syntax in heredocs:Root cause: Expression wrapping happened after extraction, so newly created
${{ }}expressions were never replaced with placeholders.Fix: Reorder compilation to wrap conditionals before extracting expressions:
Result:
Changes:
wrapExpressionsInTemplateConditionals()before expression extraction incompiler_yaml.goOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.