Fix inconsistent Markdown capitalization in CLI help text#3706
Fix inconsistent Markdown capitalization in CLI help text#3706
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Update line 45: "markdown" → "Markdown" in newCmd.Short - Update line 46: "markdown" → "Markdown" in newCmd.Long - Update line 123: "markdown" → "Markdown" in compileCmd.Long - Update line 125: "markdown" → "Markdown" in compileCmd.Long - Update line 137: "markdown" → "Markdown" in comment example Markdown is a proper noun and should be consistently capitalized. All changes verified with build, tests, and manual help text inspection. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Update line 35: "markdown file" → "Markdown file" in rootCmd.Long Complete fix for consistent Markdown capitalization across all CLI help text. Note: Parameter placeholder "[markdown-file]" on line 121 intentionally kept lowercase as per CLI naming conventions for parameters. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR addresses inconsistent capitalization of "Markdown" in CLI help text, standardizing it as a proper noun throughout. However, it also includes unrelated changes to 65 compiled workflow files that add patch file detection functionality.
Main Changes
- Markdown Capitalization Fix: Updated 6 instances in
cmd/gh-aw/main.goto consistently capitalize "Markdown" as a proper noun in CLI help text (lines 35, 45, 46, 123, 125, 137) - Unrelated Workflow Changes: Added
has_patchoutput detection to 65.lock.ymlworkflow files, which appears to be a separate feature for patch file handling
Reviewed Changes
Copilot reviewed 66 out of 66 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/gh-aw/main.go | Fixed inconsistent capitalization: changed "markdown" to "Markdown" in 6 locations across root, new, and compile command help text |
| .github/workflows/*.lock.yml (65 files) | Unrelated change: Added has_patch output to agent job, patch file existence check, and updated detection job condition to include patch detection |
Note: The workflow file changes appear to be unrelated to the stated PR purpose and should ideally be in a separate PR for better maintainability and change tracking.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| GH_AW_ASSETS_MAX_SIZE_KB: 10240 | ||
| GH_AW_SAFE_OUTPUTS: /tmp/gh-aw/safeoutputs/outputs.jsonl | ||
| outputs: | ||
| has_patch: ${{ steps.collect_output.outputs.has_patch }} |
There was a problem hiding this comment.
This PR includes unrelated changes beyond the stated purpose of fixing Markdown capitalization. The changes to all .lock.yml workflow files add:
- A new
has_patchoutput to the agent job - Logic to detect if a patch file exists at
/tmp/gh-aw/aw.patch - A new condition for the detection job:
|| needs.agent.outputs.has_patch == 'true'
These workflow changes appear to be a separate feature addition (possibly related to patch file handling) and should ideally be in a separate PR. Including unrelated changes in a PR makes it harder to review, understand the change history, and potentially revert changes if needed.
Recommendation: Consider splitting these changes into two PRs:
- One for the Markdown capitalization fix (the originally stated purpose)
- One for the patch detection feature in workflows
The CLI help text inconsistently capitalized "Markdown" - some instances used lowercase "markdown" while others correctly used "Markdown" as a proper noun.
Changes
Updated 6 instances in
cmd/gh-aw/main.goto consistently capitalize "Markdown":"a markdown file"→"a Markdown file""workflow markdown file"→"workflow Markdown file""markdown"→"Markdown"in description and examplesPreserved: Parameter placeholder
[markdown-file]remains lowercase per CLI conventions.Before/After
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.