fix: update wasm golden files to include GH_HOST env var in Copilot CLI install step#24330
Merged
fix: update wasm golden files to include GH_HOST env var in Copilot CLI install step#24330
Conversation
…LI install step Agent-Logs-Url: https://github.com/github/gh-aw/sessions/f24f32e4-5c2f-4cde-a97c-27365f013aa0 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 3, 2026 15:09
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates wasm compile-fixture golden outputs to match the current generated workflow YAML, specifically reflecting the newly added GH_HOST: github.com environment variable on the “Install GitHub Copilot CLI” step.
Changes:
- Updated
basic-copilot.goldento includeenv: GH_HOST: github.comon the Copilot CLI install step. - Updated
with-imports.goldento includeenv: GH_HOST: github.comon the Copilot CLI install step.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.golden | Aligns golden output with generated workflow by adding GH_HOST: github.com to the Copilot CLI install step env. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.golden | Same golden update as above for the with-imports fixture output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing
TestWasmGolden_CompileFixturestests (basic-copilotandwith-imports).The golden files were out of date — a recent change added
GH_HOST: github.comto theenvblock of the "Install GitHub Copilot CLI" step, but the golden files weren't updated to match.Changes
Updated golden files:
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.goldenpkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.goldenBoth files now include:
on the
Install GitHub Copilot CLIstep.Reference: https://github.com/github/gh-aw/actions/runs/23950605290/job/69857142842