Hey @github-actions[bot] 👋 — great catch on the TS2502 self-referential type annotation in parse_mcp_gateway_log.cjs! The fix is surgical and correct — swapping {typeof core} to {typeof import('@actions/core')} aligns perfectly with the established pattern already used in generate_aw_info.cjs, generate_mcp_scripts_config.cjs, and generate_workflow_overview.cjs.

One small thing to note:

• No test-file changes in the diff — the PR body confirms all 72 existing tests in parse_mcp_gateway_log.test.cjs still pass and npx tsc --noEmit is clean, but the diff itself doesn't include a test-file touch. For pure JSDoc/type-annotation fixes this is often acceptable, but it does mean the type constraint isn't under automated test coverage. Consider whether a tsc --noEmit step in CI would make this kind of regression self-detecting going forward.

If you'd like a coding agent to do a broader sweep, here's a ready-to-use prompt:

In the repository github/gh-aw, scan all .cjs files under actions/setup/js/ for any remaining JSDoc `@param` or `@type` annotations that reference `{typeof core}` (without an explicit import path) instead of `{typeof import('`@actions/core`')}` or another explicit module import path.

For each instance found:
1. Update the annotation to use the explicit `typeof import(...)` pattern, matching the style in generate_aw_info.cjs, generate_mcp_scripts_config.cjs, and generate_workflow_overview.cjs.
2. Run `npx tsc --noEmit` from the repo root to confirm no TS2502 or similar errors remain.
3. Run `make test-unit` and the relevant JS test suite to confirm all tests still pass.

Commit all changes with message: "fix: replace bare typeof core JSDoc annotations with explicit import paths"

🤖 Contribution check: 🟢 Aligned · quality: needs-work (no test-file diff) · 2 lines changed · 1 file

Generated by Contribution Check · ◷

@copilot fix tests https://github.com/github/gh-aw/actions/runs/23894994366/job/69677437252

@copilot fix tests https://github.com/github/gh-aw/actions/runs/23894994366/job/69677437252

Fixed in a352850. The mockCore in the test was missing a debug method — writeStepSummaryWithTokenUsage calls coreObj.debug(...) when the token usage file doesn't exist, which threw a TypeError, got caught by main()'s try-catch, and prevented summary.write() from ever being called. Added debug: vi.fn() to the mock.

@copilot Fix test

https://github.com/github/gh-aw/actions/runs/23895525680/job/69679456610#step:7:1

@copilot Fix test

https://github.com/github/gh-aw/actions/runs/23895525680/job/69679456610#step:7:1

The PR was merged during my session, deleting the branch — so I'm unable to push the fix (branch protection prevents recreating ci-fix/ refs).

The TS2345 error is now present in main. The fix is a 1-line JSDoc change in actions/setup/js/parse_mcp_gateway_log.cjs (line 101):

- * @param {{totalInputTokens: number, ...byModel: Object}} summary
+ * @param {{totalInputTokens: number, ...byModel: Object} | null} summary

generateTokenUsageSummary already handles null at line 107 (if (!summary || ...) return ""), but its JSDoc type annotation didn't reflect that — and commit 2a608ee13 changed the call site to pass the result of parseTokenUsageJsonl(...) directly (which returns T | null), surfacing TS2345.