fix: use assert.Positive instead of assert.Greater with 0 in testifylint#23910
Merged
fix: use assert.Positive instead of assert.Greater with 0 in testifylint#23910
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/4e2b61d3-8b54-4308-8335-5b00ecf07c74 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 1, 2026 14:40
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves a CI lint failure from testifylint by replacing a non-idiomatic numeric assertion with the preferred testify/assert helper.
Changes:
- Replace
assert.Greater(..., 0, ...)withassert.Positive(...)inTestErrorCollectorAdd_Aggregate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI lint was failing due to a
testifylintviolation inpkg/workflow/error_aggregation_test.go.Change
Replace
assert.Greater(t, collector.Count(), 0, ...)with the idiomaticassert.Positive(t, collector.Count(), ...):