[slides] Fix mcp-servers allowed field syntax in slides#23749
Merged
Conversation
The 'allowed' field in mcp-servers config must be an array (per schema and all documentation examples), not a bare string. Fix 'allowed: "*"' to 'allowed: ["*"]' to match correct syntax. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the slide deck’s MCP Servers Configuration example to match the MCP config JSON schema by making allowed an array rather than a scalar string.
Changes:
- Changed
allowed: "*"toallowed: ["*"]in the MCP servers YAML example.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slide Deck Updates
Changes Made
allowed: "*"→allowed: ["*"]in the MCP Servers Configuration slide — theallowedfield must be an array per the JSON schema and all other documentation examplesLayout Issues Fixed
Content Sources Reviewed
pkg/parser/schemas/mcp_config_schema.json— confirmsallowedtype isarraydocs/src/content/docs/reference/tools.mdanddocs/src/content/docs/guides/mcps.md— all examples use["*"]array syntaxallowed: ["fetch"](correct)Focus Mode
Global Sweep (default)
Verification: Content manually reviewed against schema definitions and reference documentation.