[instructions] Sync github-agentic-workflows.md with v0.40.1#19902
[instructions] Sync github-agentic-workflows.md with v0.40.1#19902
Conversation
Add missing `skip-if-match` and `skip-if-no-match` fields from the `on:` section. Both fields exist in the JSON schema and compiler code but were absent from the instructions file. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the agentic workflows instruction documentation to reflect newly supported on: frontmatter fields introduced/available in v0.40.1.
Changes:
- Documented
on.skip-if-match(string/object) with examples and threshold behavior. - Documented
on.skip-if-no-match(string/object) with examples and threshold behavior.
Comments suppressed due to low confidence (1)
.github/aw/github-agentic-workflows.md:108
- The summary wording here is inaccurate for the object form: the workflow is skipped when the search result count is below the configured
minthreshold (default 1), not only when there are "no results". Consider rephrasing to "...when a search query returns fewer thanminresults" to match the implementation (totalCount < min).
- **`skip-if-no-match:`** - Skip workflow execution when a GitHub search query returns no results (string or object)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| - **`skip-bots:`** - Skip workflow execution when triggered by specific GitHub actors (array) | ||
| - Bot name matching is flexible (handles with/without `[bot]` suffix) | ||
| - Example: `skip-bots: [dependabot, renovate]` - Skip for Dependabot and Renovate | ||
| - **`skip-if-match:`** - Skip workflow execution when a GitHub search query returns results (string or object) |
There was a problem hiding this comment.
The summary wording here is inaccurate for the object form: the workflow is skipped only when the search result count meets/exceeds the configured max threshold (default 1), not whenever it merely "returns results". Consider rephrasing to something like "...when a search query returns at least max results" to match the implementation (totalCount >= max).
This issue also appears on line 108 of the same file.
Instructions Update - Synchronized with v0.40.1
This PR updates
github-agentic-workflows.mdbased on a code-vs-instructions audit performed since the last release.Changes Made
skip-if-matchandskip-if-no-matchto theon:field documentation. Both fields are defined inpkg/parser/schemas/main_workflow_schema.jsonand implemented inpkg/workflow/stop_after.go+pkg/workflow/compiler_pre_activation_job.go, but were entirely absent from the instructions file.Documentation Commits Reviewed
7e32c82[dead-code] chore: remove 10 dead functions from analyzer batch run — no docs changes, Go-onlyValidation
main_workflow_schema.json,stop_after.go)