Reclassify 5 minor changesets as major breaking changes#19870
Conversation
…n guidance Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Reclassifies five previously-minor changesets to major because they describe breaking schema/behavior changes, and adds explicit breaking-change notices plus migration guidance.
Changes:
- Update
.changeset/*frontmatter to"gh-aw": majorfor five breaking changesets. - Add
⚠️ Breaking Change sections describing the breaking impact. - Add brief migration guides with before/after examples and references to
gh aw fixwhere applicable.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .changeset/minor-update-mcpg-v0-1-5.md | Marks as major and adds breaking-change + migration guidance for MCP Gateway v0.1.5 validation changes. |
| .changeset/minor-rename-llmgateway-port.md | Marks as major and adds breaking-change + migration guidance for supportsLLMGateway → llmGatewayPort change. |
| .changeset/minor-rename-app-to-github-app.md | Marks as major and adds breaking-change + migration guidance for app: → github-app: rename. |
| .changeset/minor-disable-agent-sandbox-only.md | Marks as major and adds breaking-change + migration guidance for sandbox: false removal in favor of sandbox.agent: false. |
| .changeset/minor-decouple-status-comment.md | Marks as major and adds breaking-change + migration guidance for status-comment default behavior change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| "gh-aw": minor | ||
| "gh-aw": major | ||
| --- | ||
| Removed the deprecated top-level `sandbox: false` option and replaced it with `sandbox.agent: false`, so only the agent firewall can be disabled while the MCP gateway stays enabled. Add `gh aw fix` to migrate existing workflows. |
There was a problem hiding this comment.
The summary sentence ends with “Add gh aw fix to migrate…”, which reads like users should add that text to a workflow rather than run the command. Consider rephrasing to “Run gh aw fix to migrate existing workflows” (or similar) for clarity.
| Removed the deprecated top-level `sandbox: false` option and replaced it with `sandbox.agent: false`, so only the agent firewall can be disabled while the MCP gateway stays enabled. Add `gh aw fix` to migrate existing workflows. | |
| Removed the deprecated top-level `sandbox: false` option and replaced it with `sandbox.agent: false`, so only the agent firewall can be disabled while the MCP gateway stays enabled. Run `gh aw fix` to migrate existing workflows. |
| --- | ||
| Renamed the agentic workflow engine's `supportsLLMGateway` flag to `llmGatewayPort`, made the gateway port mandatory and validated, removed the `SupportsLLMGateway` interface hooks, and consolidated API proxy/host-access workflow flags. | ||
|
|
||
| **⚠️ Breaking Change**: The `supportsLLMGateway` field has been renamed to `llmGatewayPort` and is now mandatory (previously optional). The `SupportsLLMGateway` interface hooks have been removed. |
There was a problem hiding this comment.
This states llmGatewayPort is “mandatory”, but later the migration guide says it’s required only “when enabling LLM gateway support”. Please align the wording so it’s unambiguous whether llmGatewayPort is always required or only required when a separate enablement condition is true.
| breaking rules (Docker-only TOML stdio servers, explicit mount modes, and no | ||
| mounts on HTTP MCP servers). | ||
|
|
||
| **⚠️ Breaking Change**: MCP Gateway v0.1.5 introduces stricter validation rules that reject configurations that were previously valid. | ||
|
|
||
| **Migration guide:** | ||
| - **stdio MCP servers** must now use Docker-only TOML configuration; non-Docker stdio servers are no longer supported |
There was a problem hiding this comment.
The migration bullets mention “Docker-only TOML configuration” for stdio servers, but the example shows only a YAML change from command: to image: and doesn’t illustrate any TOML requirement. Either update the example/migration to show the TOML configuration step (if required) or remove “TOML” wording to avoid misleading guidance.
| breaking rules (Docker-only TOML stdio servers, explicit mount modes, and no | |
| mounts on HTTP MCP servers). | |
| **⚠️ Breaking Change**: MCP Gateway v0.1.5 introduces stricter validation rules that reject configurations that were previously valid. | |
| **Migration guide:** | |
| - **stdio MCP servers** must now use Docker-only TOML configuration; non-Docker stdio servers are no longer supported | |
| breaking rules (Docker-only stdio servers, explicit mount modes, and no | |
| mounts on HTTP MCP servers). | |
| **⚠️ Breaking Change**: MCP Gateway v0.1.5 introduces stricter validation rules that reject configurations that were previously valid. | |
| **Migration guide:** | |
| - **stdio MCP servers** must now use Docker-only configuration; non-Docker stdio servers are no longer supported |
Five changesets were incorrectly classified as
minordespite describing breaking schema changes, field renames, and behavior changes per the criteria inscratchpad/breaking-cli-rules.md.Reclassified changesets
minor-disable-agent-sandbox-only.mdsandbox: false→sandbox.agent: false; rungh aw fixminor-rename-app-to-github-app.mdapp:→github-app:; codemod viagh aw fixminor-rename-llmgateway-port.mdsupportsLLMGateway: true→llmGatewayPort: <port>minor-decouple-status-comment.mdstatus-comment: trueto restore prior behaviorminor-update-mcpg-v0-1-5.mdEach changeset now sets
"gh-aw": majorand includes a⚠️ Breaking Changenotice with a before/after migration example.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.