[instructions] Sync github-agentic-workflows.md with release v0.40.1#19777
[instructions] Sync github-agentic-workflows.md with release v0.40.1#19777
Conversation
… property The activation-comments field was incorrectly documented under the messages: section. Per the JSON schema and parsing code, it is a top-level safe-outputs property — not a messages sub-field. Removes it from the messages list and adds it as a standalone top-level safe-outputs global configuration entry with accurate description of its boolean/expression semantics. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the instructions documentation to reflect the current safe-outputs.activation-comments configuration shape/behavior as of release v0.40.1.
Changes:
- Removes
activation-commentsfrom thesafe-outputs.messagesmessage-type list. - Documents
activation-commentsas a top-levelsafe-outputsproperty (boolean / expression) with updated description.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| - `activation-comments:` - Disable all activation and fallback comments (boolean or expression, default: `true`) | ||
| - When `false`, disables run-started, run-success, run-failure, and PR/issue creation link comments |
There was a problem hiding this comment.
The summary line for activation-comments is misleading: it says "Disable all activation and fallback comments" while also stating the default is true. Per the schema/go parsing, activation-comments defaults to enabled and only disables when set to false/"false". Consider rephrasing the first line to reflect that it enables activation comments by default (or that setting it to false disables them), to avoid reading as a disable-flag that’s on by default.
| - `activation-comments:` - Disable all activation and fallback comments (boolean or expression, default: `true`) | |
| - When `false`, disables run-started, run-success, run-failure, and PR/issue creation link comments | |
| - `activation-comments:` - Control activation and fallback comments (boolean or expression, default: `true` — comments enabled) | |
| - When `false`, disables run-started, run-success, run-failure, and PR/issue creation link comments; when `true` (default), these comments are enabled |
Instructions Update - Synchronized with v0.40.1
This PR updates the
github-agentic-workflows.mdinstructions file based on a code audit of safe-outputs behavior since the last release.Changes Made
activation-commentsplacement: Moved from themessages:sub-list to a top-levelsafe-outputs:global property, matching the JSON schema (main_workflow_schema.json) and parsing code (safe_outputs_config.go). The field was incorrectly documented as a message type, but it is parsed from the top-levelsafe-outputsmap — not frommessages.Documentation Commits Reviewed
b28e620fix: update wasm golden files for action pin changes (no docs impact)Code Files Audited
pkg/workflow/compiler_types.go— SafeOutputsConfig structpkg/workflow/safe_outputs_config.go— activation-comments parsed at top level, stored in Messages fieldpkg/parser/schemas/main_workflow_schema.json— activation-comments is a top-level safe-outputs property; not present under messagesValidation