This PR applies targeted simplifications to recently merged code (last 24 hours) to improve clarity, consistency, and idiomaticity while preserving all functionality.

Files Simplified

• pkg/fileutil/tar.go — use errors.Is(err, io.EOF) instead of direct == comparison
• pkg/parser/schema_utilities.go — inline single-use ignored variable
• pkg/cli/audit_report_analysis.go — split long sliceutil.Map call for readability

Improvements Made

1. Idiomatic error comparison (pkg/fileutil/tar.go)

Changed err == io.EOF to errors.Is(err, io.EOF). The project has errorlint enabled in .golangci.yml which flags direct sentinel error comparisons in favour of errors.Is. This is consistent with Go 1.13+ best practices.

2. Inline single-use variable (pkg/parser/schema_utilities.go)

Removed the intermediate ignored variable that was assigned and immediately used in the next if statement. The inline form is more direct and removes unnecessary indirection.

Before:

ignored := slices.Contains(constants.IgnoredFrontmatterFields, key)
if ignored {

After:

if slices.Contains(constants.IgnoredFrontmatterFields, key) {

3. Split long line (pkg/cli/audit_report_analysis.go)

Broke a single long sliceutil.Map(...) call (>120 chars) onto multiple lines, improving readability without changing behavior.

Changes Based On

Recent PRs from the last 24 hours:

• [fp-enhancer] Improve pkg/cli: use sliceutil.Filter/Map for functional slice operations #19705 — fp-enhancer: sliceutil.Filter/Map usage (introduced the long line)
• [log] Add debug logging to tar, schema utilities, MCP config types, and wizard command #19651 — Add debug logging to tar, schema utilities, MCP config types, and wizard command (introduced the ignored variable and err == io.EOF)

Testing

• ✅ Build passes (go build ./...)
• ✅ Package tests pass (go test ./pkg/fileutil/... ./pkg/parser/...)
• ✅ Code formatted (make fmt)
• ✅ No functional changes — behavior is identical

Review Focus

Please verify:

• The errors.Is change is semantically equivalent (it is — io.EOF is a simple sentinel, not wrapped)
• The inlined variable doesn't reduce clarity (it doesn't — ignored added no meaning beyond the expression itself)
• The multi-line Map call is readable (it is — matches Go conventions for multi-arg function calls)

References: §22732114386

Generated by Code Simplifier · ◷

• expires on Mar 6, 2026, 7:10 PM UTC