Add "imports" field to frontmatter for importing workflow specifications#1249
Merged
Add "imports" field to frontmatter for importing workflow specifications#1249
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add imports field to front matter for workflow specifications
Add "imports" field to frontmatter for importing workflow specifications
Oct 6, 2025
pelikhan
reviewed
Oct 6, 2025
Contributor
Author
|
@pelikhan Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
…y list Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…ield-to-front-matter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
Code Review Feedback Addressed:
processImportsWithWorkflowSpecto useworkflow.MarshalWithFieldOrderwithconstants.PriorityWorkflowFieldsfor proper field orderingPriorityWorkflowFieldsinpkg/constants/constants.go(positioned after "network" and before "safe-outputs")reconstructWorkflowFileFromMaphelper function that uses the proper YAML marshaling andworkflow.UnquoteYAMLKeyto handle the "on" key correctlyAll tests pass and workflows compile successfully.
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.