-
Notifications
You must be signed in to change notification settings - Fork 327
Remote workflow call still broken #24422
Copy link
Copy link
Closed
2 / 22 of 2 issues completedLabels
Description
Two bugs are interacting in cross-repo reusable workflows:
- The stale lock check resolves the caller workflow instead of the callee reusable workflow, so it looks for the
.mdand.lock.ymlin the wrong repo and fails as "outdated or unverifiable". on.stale-check: falseis treated as an internal gh-aw flag but is still emitted into the compiled rooton:block, producing invalid GitHub Actions YAML.
Observed behavior
In the failing case, the lock check resolved the source repo to the caller repo and then tried to fetch the reusable workflow files there, where they do not exist.
At the same time, trying to disable the check in source frontmatter with:
on:
workflow_call:
stale-check: falsecompiles to invalid YAML like:
on:
stale-check: false
workflow_call:which GitHub rejects.
Expected behavior
- Cross-repo reusable workflow lock checks should resolve the callee reusable workflow as the source of truth.
on.stale-checkshould affect compiler behavior only and must not be emitted into the final workflow YAML.
Suggested fix
- Resolve reusable workflow source from the Actions run
referenced_workflowsdata instead ofgithub.workflow_ref/GITHUB_WORKFLOW_REF. - Strip
stale-checkfrom the parsedonmap before serializing the compiled rooton:section.
Reactions are currently unavailable
Metadata
Metadata
Labels
Type
Fields
Give feedbackNo fields configured for issues without a type.