Objective
Suppress the systemic shellcheck/SC1003 false positives in actionlint that generate 156 noisy findings across 28 workflows, as reported in discussion #18283.
Context
Shellcheck incorrectly reports SC1003 (single-quote escaping issue) on --allow-domains URL list arguments in AWF commands. These arguments contain domain name strings inside double-quoted shell expressions — shellcheck misidentifies single quotes in domain names (e.g., can't) as problematic. These are false positives with no real security impact.
- Tool: actionlint / shellcheck
- Count: 156 occurrences across 28 workflows
- Pattern: AWF
--allow-domains arguments with domain names containing single quotes
Approach
- Check if actionlint supports a configuration file (
.github/actionlint.yaml or .actionlint.yaml)
- Add SC1003 suppression to the actionlint config:
# .github/actionlint.yaml
shellcheck:
disable:
- SC1003
Or alternatively, identify the AWF command template that generates these steps and add an inline shellcheck disable comment:
# shellcheck disable=SC1003
gh aw run --allow-domains "..."
- If suppression is added to a compiled workflow template in Go code (e.g., in
pkg/workflow/), find the relevant template and add the disable comment there
- Run
make recompile to regenerate all .lock.yml files
- Run
make agent-finish to validate
Files to Modify
.github/actionlint.yaml (create if not exists) — add SC1003 suppression
- OR the relevant Go template in
pkg/workflow/ that generates the --allow-domains step
Acceptance Criteria
Generated by Plan Command for issue #discussion #18283
Objective
Suppress the systemic
shellcheck/SC1003false positives in actionlint that generate 156 noisy findings across 28 workflows, as reported in discussion #18283.Context
Shellcheck incorrectly reports
SC1003(single-quote escaping issue) on--allow-domainsURL list arguments in AWF commands. These arguments contain domain name strings inside double-quoted shell expressions — shellcheck misidentifies single quotes in domain names (e.g.,can't) as problematic. These are false positives with no real security impact.--allow-domainsarguments with domain names containing single quotesApproach
.github/actionlint.yamlor.actionlint.yaml)Or alternatively, identify the AWF command template that generates these steps and add an inline shellcheck disable comment:
pkg/workflow/), find the relevant template and add the disable comment theremake recompileto regenerate all.lock.ymlfilesmake agent-finishto validateFiles to Modify
.github/actionlint.yaml(create if not exists) — add SC1003 suppressionpkg/workflow/that generates the--allow-domainsstepAcceptance Criteria
--allow-domainsstepsmake recompilesucceedsmake agent-finishpasses