CI Failure Investigation - Run #37485
Summary
The js job in run 22296273341 fails because actions/setup/js/messages.test.cjs still asserts XML markers without the id metadata that generateXMLMarker now appends from GITHUB_RUN_ID.
Failure Details
Root Cause Analysis
generateXMLMarker reads GITHUB_RUN_ID and always inserts an id: (run-id) segment (plus workflow_id when that env var is present). The unit tests in messages.test.cjs still expect strings that omit that extra field, so every AssertionError compares the literal string without id: against the actual string that contains id: 22296273341 (and variants that also include engine metadata/ tracker ids).
Failed Jobs and Errors
js (cd actions/setup/js && npm test) fails while executing messages.test.cjs.
- Matching error:
AssertionError: expected '' to be ''.
- The same mismatch recurs for the four additional XML marker tests that add engine metadata or tracker IDs.
Investigation Findings
- Five
generateXMLMarker assertions now fail because the runtime output gained an id: attribute sourced from GITHUB_RUN_ID.
- The job is run with
GITHUB_RUN_ID, so the generated marker now always contains id: 22296273341 regardless of other metadata.
- Reproduce locally by running
cd actions/setup/js && npm ci && npm test (same commands executed in the CI job).
Recommended Actions
Prevention Strategies
Always refresh literal string expectations (messages.test.cjs, generate_footer.test.cjs, etc.) whenever new GH_AW_* or GITHUB_* metadata fields are added to generateXMLMarker so the test harness matches production behavior.
AI Team Self-Improvement
Note in future instructions that adding new metadata to generateXMLMarker requires revisiting the XML marker tests to include the new fields.
Historical Context
No existing [CI Failure Doctor] issue targets run #37485; previous investigations have covered other build or validation regressions but not this JS test mismatch.
🩺 Diagnosis provided by CI Failure Doctor
To install this workflow, run gh aw add githubnext/agentics/workflows/ci-doctor.md@ea350161ad5dcc9624cf510f134c6a9e39a6f94d. View source at https://github.com/githubnext/agentics/tree/ea350161ad5dcc9624cf510f134c6a9e39a6f94d/workflows/ci-doctor.md.
CI Failure Investigation - Run #37485
Summary
The
jsjob in run 22296273341 fails becauseactions/setup/js/messages.test.cjsstill asserts XML markers without theidmetadata thatgenerateXMLMarkernow appends fromGITHUB_RUN_ID.Failure Details
mainRoot Cause Analysis
generateXMLMarkerreadsGITHUB_RUN_IDand always inserts anid: (run-id)segment (plusworkflow_idwhen that env var is present). The unit tests inmessages.test.cjsstill expect strings that omit that extra field, so everyAssertionErrorcompares the literal string withoutid:against the actual string that containsid: 22296273341(and variants that also include engine metadata/ tracker ids).Failed Jobs and Errors
js(cd actions/setup/js && npm test) fails while executingmessages.test.cjs.AssertionError: expected '' to be ''.Investigation Findings
generateXMLMarkerassertions now fail because the runtime output gained anid:attribute sourced fromGITHUB_RUN_ID.GITHUB_RUN_ID, so the generated marker now always containsid: 22296273341regardless of other metadata.cd actions/setup/js && npm ci && npm test(same commands executed in the CI job).Recommended Actions
generateXMLMarker’s unit tests (and any literal footer fixtures) to expect theidmetadata, or adjust the implementation so tests can opt out of includingidin the marker string.Prevention Strategies
Always refresh literal string expectations (
messages.test.cjs,generate_footer.test.cjs, etc.) whenever newGH_AW_*orGITHUB_*metadata fields are added togenerateXMLMarkerso the test harness matches production behavior.AI Team Self-Improvement
Note in future instructions that adding new metadata to
generateXMLMarkerrequires revisiting the XML marker tests to include the new fields.Historical Context
No existing
[CI Failure Doctor]issue targets run #37485; previous investigations have covered other build or validation regressions but not this JS test mismatch.