-
Notifications
You must be signed in to change notification settings - Fork 277
Closed
Labels
Description
Description
The compiler_yaml_main_job.go file (612 lines) currently lacks a dedicated test file. Main job generation is a critical path in the workflow compilation process and needs direct unit tests rather than only indirect integration testing.
Suggested Changes
Create pkg/workflow/compiler_yaml_main_job_test.go with comprehensive test coverage for:
- Repository import checkout generation
- Runtime deduplication logic
- Custom steps insertion
- Edge cases in main job generation
Files Affected
pkg/workflow/compiler_yaml_main_job_test.go(new file)- Test patterns should follow existing test conventions from similar compiler test files
Success Criteria
- Test file created with at least 10 test cases
- Coverage for repository import logic
- Coverage for runtime setup logic
- Coverage for custom steps handling
- All existing integration tests continue to pass
Source
Extracted from Daily Compiler Code Quality Report discussion #13934
Original recommendation:
Missing Dedicated Test File (High Priority)
- Current: No
compiler_yaml_main_job_test.gofile exists- Concern: Main job generation is tested only indirectly through integration tests
- Impact: Harder to validate edge cases and regression test specific behaviors
- Estimated Effort: 2-4 hours
Priority
High - Improves regression testing for critical compilation path
AI generated by Discussion Task Miner - Code Quality Improvement Agent
- expires on Feb 7, 2026, 9:12 AM UTC
Reactions are currently unavailable