fix: align CJS error messages with main branch to fix CI test failures

Copilot · pelikhan · web-flow · commit f8d58bb42ed3 · 2026-04-03T02:30:26.000Z
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/f49e39ad-fc0f-44fc-a75c-4c451342b736 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
diff --git a/actions/setup/js/check_workflow_timestamp_api.cjs b/actions/setup/js/check_workflow_timestamp_api.cjs
@@ -2,10 +2,12 @@
 /// <reference types="@actions/github-script" />
 
 /**
- * Check workflow lock file integrity using frontmatter hash validation.
+ * Check for a stale workflow lock file using frontmatter hash comparison.
  * This script verifies that the stored frontmatter hash in the lock file
- * matches the recomputed hash from the source .md file, regardless of
- * commit timestamps.
+ * matches the recomputed hash from the source .md file, detecting cases where
+ * the workflow was edited without recompiling the lock file. It does not
+ * provide tamper protection — use code review to guard against intentional
+ * modifications.
  *
  * Supports both same-repo and cross-repo reusable workflow scenarios:
  * - Primary: GitHub API (uses GITHUB_WORKFLOW_REF to identify source repo)
@@ -33,7 +35,7 @@ async function main() {
   const workflowMdPath = `.github/workflows/${workflowBasename}.md`;
   const lockFilePath = `.github/workflows/${workflowFile}`;
 
-  core.info(`Checking workflow lock file integrity using frontmatter hash:`);
+  core.info(`Checking for stale lock file using frontmatter hash:`);
   core.info(`  Source: ${workflowMdPath}`);
   core.info(`  Lock file: ${lockFilePath}`);
 
@@ -203,11 +205,11 @@ async function main() {
   if (!hashComparison) {
     // Could not compute hash - be conservative and fail
     core.warning("Could not compare frontmatter hashes - assuming lock file is outdated");
-    const warningMessage = `Lock file '${lockFilePath}' integrity check failed! Could not verify frontmatter hash for '${workflowMdPath}'. Run 'gh aw compile' to regenerate the lock file.`;
+    const warningMessage = `Lock file '${lockFilePath}' is outdated or unverifiable! Could not verify frontmatter hash for '${workflowMdPath}'. Run 'gh aw compile' to regenerate the lock file.`;
 
     let summary = core.summary
       .addRaw("### ⚠️ Workflow Lock File Warning\n\n")
-      .addRaw("**WARNING**: Lock file integrity check failed. Could not verify frontmatter hash.\n\n")
+      .addRaw("**WARNING**: Could not verify whether lock file is up to date. Frontmatter hash check failed.\n\n")
       .addRaw("**Files:**\n")
       .addRaw(`- Source: \`${workflowMdPath}\`\n`)
       .addRaw(`- Lock: \`${lockFilePath}\`\n\n`)
diff --git a/actions/setup/js/check_workflow_timestamp_api.test.cjs b/actions/setup/js/check_workflow_timestamp_api.test.cjs
@@ -235,7 +235,7 @@ jobs:
       await main();
 
       expect(mockCore.warning).toHaveBeenCalledWith(expect.stringContaining("Could not compare frontmatter hashes"));
-      expect(mockCore.setFailed).toHaveBeenCalledWith(expect.stringContaining("integrity check failed"));
+      expect(mockCore.setFailed).toHaveBeenCalledWith(expect.stringContaining("outdated or unverifiable"));
       expect(mockCore.summary.addRaw).toHaveBeenCalled();
       expect(mockCore.summary.write).toHaveBeenCalled();
     });
@@ -246,7 +246,7 @@ jobs:
       await main();
 
       expect(mockCore.warning).toHaveBeenCalledWith(expect.stringContaining("Could not compare frontmatter hashes"));
-      expect(mockCore.setFailed).toHaveBeenCalledWith(expect.stringContaining("integrity check failed"));
+      expect(mockCore.setFailed).toHaveBeenCalledWith(expect.stringContaining("outdated or unverifiable"));
       expect(mockCore.summary.addRaw).toHaveBeenCalled();
       expect(mockCore.summary.write).toHaveBeenCalled();
     });
@@ -348,7 +348,7 @@ engine: claude
 
       expect(mockCore.info).toHaveBeenCalledWith(expect.stringContaining("Unable to fetch lock file content"));
       expect(mockCore.warning).toHaveBeenCalledWith(expect.stringContaining("Could not compare frontmatter hashes"));
-      expect(mockCore.setFailed).toHaveBeenCalledWith(expect.stringContaining("integrity check failed"));
+      expect(mockCore.setFailed).toHaveBeenCalledWith(expect.stringContaining("outdated or unverifiable"));
     });
   });
 
@@ -700,7 +700,7 @@ engine: copilot
       expect(mockCore.info).toHaveBeenCalledWith(expect.stringContaining("Unable to fetch lock file content for hash comparison via API"));
       expect(mockCore.info).toHaveBeenCalledWith(expect.stringContaining("GITHUB_WORKSPACE not available"));
       expect(mockCore.warning).toHaveBeenCalledWith(expect.stringContaining("Could not compare frontmatter hashes"));
-      expect(mockCore.setFailed).toHaveBeenCalledWith(expect.stringContaining("integrity check failed"));
+      expect(mockCore.setFailed).toHaveBeenCalledWith(expect.stringContaining("outdated or unverifiable"));
     });
 
     it("should fail when API fails and local lock file is missing", async () => {
@@ -712,7 +712,7 @@ engine: copilot
 
       expect(mockCore.info).toHaveBeenCalledWith(expect.stringContaining("Local lock file not found"));
       expect(mockCore.warning).toHaveBeenCalledWith(expect.stringContaining("Could not compare frontmatter hashes"));
-      expect(mockCore.setFailed).toHaveBeenCalledWith(expect.stringContaining("integrity check failed"));
+      expect(mockCore.setFailed).toHaveBeenCalledWith(expect.stringContaining("outdated or unverifiable"));
     });
 
     it("should use API if available even in cross-repo scenario (API preferred over local files)", async () => {
@@ -785,7 +785,7 @@ engine: copilot
       // The path traversal is rejected before any file read
       expect(mockCore.info).toHaveBeenCalledWith(expect.stringContaining("escapes workspace"));
       expect(mockCore.warning).toHaveBeenCalledWith(expect.stringContaining("Could not compare frontmatter hashes"));
-      expect(mockCore.setFailed).toHaveBeenCalledWith(expect.stringContaining("integrity check failed"));
+      expect(mockCore.setFailed).toHaveBeenCalledWith(expect.stringContaining("outdated or unverifiable"));
     });
   });
 
