Skip to content

Commit d819ce4

Browse files
Copilotpelikhan
andauthored
fix: use isStagedMode(config) for logStagedPreviewInfo to cover global env var
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw/sessions/cc74daba-05ff-43a1-a371-f1af5f87dc80
1 parent 0592bfa commit d819ce4

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

actions/setup/js/create_pr_review_comment.cjs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const { resolveTargetRepoConfig, resolveAndValidateRepo } = require("./repo_help
1010
const { sanitizeContent } = require("./sanitize_content.cjs");
1111
const { createAuthenticatedGitHubClient } = require("./handler_auth.cjs");
1212
const { buildWorkflowRunUrl } = require("./workflow_metadata_helpers.cjs");
13-
const { logStagedPreviewInfo } = require("./staged_preview.cjs");
13+
const { isStagedMode, logStagedPreviewInfo } = require("./safe_output_helpers.cjs");
1414

1515
/** @type {string} Safe output type handled by this module */
1616
const HANDLER_TYPE = "create_pull_request_review_comment";
@@ -50,6 +50,8 @@ async function main(config = {}) {
5050
// Propagate per-handler staged flag to the shared PR review buffer
5151
if (config.staged === true) {
5252
buffer.setStaged(true);
53+
}
54+
if (isStagedMode(config)) {
5355
logStagedPreviewInfo("PR review comments will be previewed without being submitted");
5456
}
5557

actions/setup/js/submit_pr_review.cjs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,10 @@
55
* @typedef {import('./types/handler-factory').HandlerFactoryFunction} HandlerFactoryFunction
66
*/
77

8-
const { resolveTarget } = require("./safe_output_helpers.cjs");
8+
const { resolveTarget, isStagedMode, logStagedPreviewInfo } = require("./safe_output_helpers.cjs");
99
const { resolveTargetRepoConfig, resolveAndValidateRepo } = require("./repo_helpers.cjs");
1010
const { createAuthenticatedGitHubClient } = require("./handler_auth.cjs");
1111
const { getErrorMessage } = require("./error_helpers.cjs");
12-
const { logStagedPreviewInfo } = require("./staged_preview.cjs");
1312

1413
/** @type {string} Safe output type handled by this module */
1514
const HANDLER_TYPE = "submit_pull_request_review";
@@ -50,6 +49,8 @@ async function main(config = {}) {
5049
// Propagate per-handler staged flag to the shared PR review buffer
5150
if (config.staged === true) {
5251
buffer.setStaged(true);
52+
}
53+
if (isStagedMode(config)) {
5354
logStagedPreviewInfo("PR review will be previewed without being submitted");
5455
}
5556

0 commit comments

Comments
 (0)