Fix Go linting issues - remove unused functions and test references

Copilot · pelikhan · Copilot · commit 96b9f068a681 · 2026-01-08T06:29:49.000Z
Co-authored-by: pelikhan &lt;4175913+pelikhan@users.noreply.github.com&gt;
diff --git a/pkg/cli/logs_report.go b/pkg/cli/logs_report.go
@@ -651,111 +651,12 @@ func buildRedactedDomainsSummary(processedRuns []ProcessedRun) *RedactedDomainsL
 
 // logErrorAggregator and related functions have been removed since error patterns are no longer supported
 
-// aggregateLogErrors has been removed since error patterns are no longer supported
-func aggregateLogErrors(processedRuns []ProcessedRun, agg interface{}) []ErrorSummary {
-	// Return empty slice since error patterns have been removed
-	return []ErrorSummary{}
-}
-
-// isActionableError checks if an error message is actionable (user-relevant)
-// Returns false for internal debug messages, validation logs, JSON fragments, etc.
-func isActionableError(message string) bool {
-	msg := strings.ToLower(message)
-
-	// Filter out internal validation/debug messages
-	debugPatterns := []string{
-		"validation completed",
-		"executePromptDirectly",
-		"starting validate_errors",
-		"loaded", "error patterns",
-		"pattern ", "/16:", // Pattern testing logs
-		"validation completed in",
-		"starting error validation",
-		"error validation completed",
-		"const { main }",
-		"require(",
-		"perfect! the",
-		"failed as expected",
-	}
-
-	for _, pattern := range debugPatterns {
-		if strings.Contains(msg, pattern) {
-			return false
-		}
-	}
-
-	// Filter out JSON fragments and data structures
-	jsonPatterns := []string{
-		`"errorCodesToRetry"`,
-		`"description":`,
-		`"statement":`,
-		`"content":`,
-		`"onRequestError"`,
-		`[{`, `}]`, `"[`,
-	}
-
-	for _, pattern := range jsonPatterns {
-		if strings.Contains(message, pattern) {
-			return false
-		}
-	}
-
-	// Filter out MCP server logs (stderr output)
-	if strings.Contains(msg, "[mcp server") ||
-		strings.Contains(msg, "[safeoutputs]") ||
-		strings.Contains(msg, "send: {\"jsonrpc\"") {
-		return false
-	}
-
-	// Filter out Squid proxy logs
-	if strings.Contains(msg, "::1:") && strings.Contains(msg, "NONE_NONE:HIER_NONE") {
-		return false
-	}
-
-	// Filter out tool invocation result logs (these are outputs, not errors)
-	if strings.HasPrefix(msg, "tool invocation result:") {
-		return false
-	}
-
-	return true
-}
-
 // buildCombinedErrorsSummary has been removed since error patterns are no longer supported
 func buildCombinedErrorsSummary(processedRuns []ProcessedRun) []ErrorSummary {
 	// Return empty slice since error patterns have been removed
 	return []ErrorSummary{}
 }
 
-// buildErrorsSummary aggregates errors and warnings across all runs
-// Returns two slices: errorsSummary and warningsSummary
-// DEPRECATED: Use buildCombinedErrorsSummary instead
-func buildErrorsSummary(processedRuns []ProcessedRun) ([]ErrorSummary, []ErrorSummary) {
-	// Get combined summary
-	combined := buildCombinedErrorsSummary(processedRuns)
-
-	// Separate into errors and warnings
-	var errorsSummary []ErrorSummary
-	var warningsSummary []ErrorSummary
-
-	for _, summary := range combined {
-		if summary.Type == "Error" {
-			errorsSummary = append(errorsSummary, summary)
-		} else {
-			warningsSummary = append(warningsSummary, summary)
-		}
-	}
-
-	// Sort each by count (descending)
-	sort.Slice(errorsSummary, func(i, j int) bool {
-		return errorsSummary[i].Count > errorsSummary[j].Count
-	})
-	sort.Slice(warningsSummary, func(i, j int) bool {
-		return warningsSummary[i].Count > warningsSummary[j].Count
-	})
-
-	return errorsSummary, warningsSummary
-}
-
 // renderLogsJSON outputs the logs data as JSON
 func renderLogsJSON(data LogsData) error {
 	reportLog.Printf("Rendering logs data as JSON: %d runs", data.Summary.TotalRuns)
diff --git a/pkg/workflow/engine_parsing_simple_test.go b/pkg/workflow/engine_parsing_simple_test.go
@@ -323,7 +323,6 @@ Line 5`,
 				metrics := engine.ParseLogMetrics(tt.logContent, tt.verbose)
 
 				// Basic validation - should return valid struct
-				}
 				if metrics.TokenUsage < 0 {
 					t.Errorf("TokenUsage should not be negative, got %d", metrics.TokenUsage)
 				}
diff --git a/pkg/workflow/metrics_test.go b/pkg/workflow/metrics_test.go
@@ -762,13 +762,10 @@ func TestFinalizeToolMetrics(t *testing.T) {
 		currentSequence []string
 		turns           int
 		tokenUsage      int
-		logContent      string
-		errorPatterns   []ErrorPattern
 		expectedTurns   int
 		expectedTokens  int
 		expectedToolLen int
 		expectedSeqLen  int
-		expectedErrors  int
 	}{
 		{
 			name:           "Basic finalization with sequence and tools",
@@ -781,13 +778,10 @@ func TestFinalizeToolMetrics(t *testing.T) {
 			currentSequence: []string{"bash", "github_search", "web_fetch"},
 			turns:           5,
 			tokenUsage:      1500,
-			logContent:      "",
-			errorPatterns:   nil,
 			expectedTurns:   5,
 			expectedTokens:  1500,
 			expectedToolLen: 3,
 			expectedSeqLen:  1,
-			expectedErrors:  0,
 		},
 		{
 			name:           "Empty sequence should not be added",
@@ -798,13 +792,10 @@ func TestFinalizeToolMetrics(t *testing.T) {
 			currentSequence: []string{},
 			turns:           2,
 			tokenUsage:      500,
-			logContent:      "",
-			errorPatterns:   nil,
 			expectedTurns:   2,
 			expectedTokens:  500,
 			expectedToolLen: 1,
 			expectedSeqLen:  0,
-			expectedErrors:  0,
 		},
 		{
 			name:           "Tools should be sorted by name",
@@ -817,36 +808,10 @@ func TestFinalizeToolMetrics(t *testing.T) {
 			currentSequence: []string{"zebra_tool", "alpha_tool"},
 			turns:           3,
 			tokenUsage:      800,
-			logContent:      "",
-			errorPatterns:   nil,
 			expectedTurns:   3,
 			expectedTokens:  800,
 			expectedToolLen: 3,
 			expectedSeqLen:  1,
-			expectedErrors:  0,
-		},
-		{
-			name:            "Error patterns should be counted",
-			initialMetrics:  LogMetrics{},
-			toolCallMap:     map[string]*ToolCallInfo{},
-			currentSequence: []string{},
-			turns:           1,
-			tokenUsage:      100,
-			logContent: `
-Error: File not found
-Warning: Deprecated API used
-Error: Connection timeout
-Info: Processing complete
-`,
-			errorPatterns: []ErrorPattern{
-				{Pattern: `(?i)error:?\s+(.+)`, LevelGroup: 0, MessageGroup: 1},
-				{Pattern: `(?i)warning:?\s+(.+)`, LevelGroup: 0, MessageGroup: 1},
-			},
-			expectedTurns:   1,
-			expectedTokens:  100,
-			expectedToolLen: 0,
-			expectedSeqLen:  0,
-			expectedErrors:  3, // 2 errors + 1 warning
 		},
 		{
 			name: "Existing sequences should be preserved",
@@ -861,13 +826,10 @@ Info: Processing complete
 			currentSequence: []string{"tool3", "tool4"},
 			turns:           2,
 			tokenUsage:      300,
-			logContent:      "",
-			errorPatterns:   nil,
 			expectedTurns:   2,
 			expectedTokens:  300,
 			expectedToolLen: 1,
 			expectedSeqLen:  2, // 1 existing + 1 new
-			expectedErrors:  0,
 		},
 	}
 

Original file line number	Diff line number	Diff line change
@@ -323,7 +323,6 @@ Line 5`,
`323`	`323`	`metrics := engine.ParseLogMetrics(tt.logContent, tt.verbose)`
`324`	`324`
`325`	`325`	`// Basic validation - should return valid struct`
`326`		`- }`
`327`	`326`	`if metrics.TokenUsage < 0 {`
`328`	`327`	`t.Errorf("TokenUsage should not be negative, got %d", metrics.TokenUsage)`
`329`	`328`	`}`