Changing number to string in example yaml#25146
Changing number to string in example yaml#25146skedwards88 merged 1 commit intogithub:mainfrom SHA65536:patch-1
Conversation
This example shows supplying go-version as a number 1.15, this works for version up to 1.19, but with 1.20, it will turn it into a number (1.2) and then back into a string "1.2" making the action use Go 1.2 instead of 1.20.
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
|
@SHA65536 Thank you for opening a PR and linking it to your issue! ✨ I'll get this triaged for review! ⚡ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
skedwards88
left a comment
There was a problem hiding this comment.
Thanks for fixing this! We'll get this merged down for you.
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
This example shows supplying go-version as a number 1.15, this works for version up to 1.19, but with 1.20, it will turn it into a number (1.2) and then back into a string "1.2" making the action use Go 1.2 instead of 1.20.
Why:
I saw someone face this issue and realized the problem came from this example on the docs.
Closes: #25145
What's being changed (if available, include any code snippets, screenshots, or gifs):
Go version type from 1.5 to '1.5' to prevent wrong version after conversion to number.
Check off the following: