Skip to content

Explain that GITHUB_SHA may not always be the commit that was pushed#15482

Merged
ramyaparimi merged 7 commits intogithub:mainfrom
danielcompton:patch-4
Mar 9, 2022
Merged

Explain that GITHUB_SHA may not always be the commit that was pushed#15482
ramyaparimi merged 7 commits intogithub:mainfrom
danielcompton:patch-4

Conversation

@danielcompton
Copy link
Copy Markdown
Contributor

@danielcompton danielcompton commented Feb 15, 2022

Why:

Closes: #15302

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 15, 2022
@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 15, 2022
@ramyaparimi
Copy link
Copy Markdown
Contributor

ramyaparimi commented Feb 15, 2022

@danielcompton
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ethomson
Copy link
Copy Markdown
Contributor

ethomson commented Mar 1, 2022

Thanks @danielcompton - this makes sense to me. 👍

skedwards88
skedwards88 reviewed Mar 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition! I left a minor wording suggestion that I will go ahead an incorporate, then we'll get this merged down for you.

@skedwards88 skedwards88 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 3, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/actions/learn-github-actions/environment-variables.md Modified Original

@ramyaparimi ramyaparimi enabled auto-merge March 3, 2022 13:45
@ramyaparimi ramyaparimi merged commit 42bac6a into github:main Mar 9, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@asbjornu asbjornu mentioned this pull request Nov 20, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skedwards88 skedwards88 skedwards88 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GITHUB_SHA on PRs refers to the merge commit, not the actual commit which triggered the PR

4 participants

@danielcompton @ramyaparimi @ethomson @skedwards88