fix(check-status): add null check for commit status rollup #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses a TypeError that occurs when trying to access the 'state' property of 'commit.statusCheckRollup' when it is null. A conditional check is added to ensure 'commit.statusCheckRollup' is not null before attempting to access 'state'. This prevents the TypeError and provides a more informative message when 'commit.statusCheckRollup' is null.
Contributor
Author
|
After further investigation into the Github GraphQL API, I have discovered that the commit.statusCheckRollup field is indeed nullable. This means that there are valid scenarios where this field can be null. This could occur if the commit does not have any status checks associated with it. Therefore these changes should at least help improving the robustness and reliability of the action when dealing with commits without associated status checks. |
GrantBirki
approved these changes
Nov 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #39.
This commit addresses a TypeError that occurs when trying to access the 'state' property of 'commit.statusCheckRollup' when it is null. A conditional check is added to ensure 'commit.statusCheckRollup' is not null before attempting to access 'state'. This prevents the TypeError and provides a more informative message when 'commit.statusCheckRollup' is null.
However, this would not solve the underlying issue of why commit.statusCheckRollup is null when it shouldn't be (see #39).
Also, if commit.statusCheckRollup being null is a valid state that indicates a certain condition (e.g., the CI status check has not been run yet), then the logic within checkStatus() may need to be updated to handle this condition appropriately.