Make various improvements to the sync tool to handle updating a bundled CodeQL Action.#48
Merged
Merged
Conversation
Co-authored-by: Simon Engledew <simon-engledew@github.com>
…sitory you are updating. Co-authored-by: Simon Engledew <simon-engledew@github.com>
…rectly is not allowed. Co-authored-by: Simon Engledew <simon-engledew@github.com>
8c30711 to
ef02b83
Compare
rneatherway
approved these changes
Nov 13, 2020
rneatherway
left a comment
There was a problem hiding this comment.
Good thinking! This is indeed a neat solution, especially considering we already have flows in the tool that require site_admin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@simon-engledew and I had a good pairing session to attempt to ensure that the sync tool works correctly for updating a bundled Action. The main behavior changes we made were improving the error message when you don't have write access to the destination repository and allowing you to impersonate the Actions admin for the purposes of updating the bundled CodeQL Action.