Skip to content

Commit 4cd47ad

Browse files
committed
Address review comments
1 parent 5fa8dad commit 4cd47ad

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

lib/init-action.js

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/config-utils.ts

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -869,21 +869,16 @@ export async function getOverlayDatabaseMode(
869869
const checkOverlayStatus = await features.getValue(
870870
Feature.OverlayAnalysisStatusCheck,
871871
);
872-
const diskUsage =
873-
performResourceChecks || checkOverlayStatus
874-
? await checkDiskUsage(logger)
875-
: undefined;
876-
if (
877-
(performResourceChecks || checkOverlayStatus) &&
878-
diskUsage === undefined
879-
) {
872+
const needDiskUsage = performResourceChecks || checkOverlayStatus;
873+
const diskUsage = needDiskUsage ? await checkDiskUsage(logger) : undefined;
874+
if (needDiskUsage && diskUsage === undefined) {
880875
logger.warning(
881876
`Unable to determine disk usage, therefore setting overlay database mode to ${OverlayDatabaseMode.None}.`,
882877
);
883878
return new Failure(OverlayDisabledReason.UnableToDetermineDiskUsage);
884879
}
885880
const resourceResult =
886-
performResourceChecks && diskUsage
881+
performResourceChecks && diskUsage !== undefined
887882
? await checkRunnerResources(
888883
codeql,
889884
diskUsage,
@@ -897,7 +892,7 @@ export async function getOverlayDatabaseMode(
897892
}
898893
if (
899894
checkOverlayStatus &&
900-
diskUsage &&
895+
diskUsage !== undefined &&
901896
(await shouldSkipOverlayAnalysis(codeql, languages, diskUsage, logger))
902897
) {
903898
logger.info(

0 commit comments

Comments
 (0)