JS: exclude field initializers in dead-store#918
Closed
asger-semmle wants to merge 1 commit intogithub:masterfrom
Closed
JS: exclude field initializers in dead-store#918asger-semmle wants to merge 1 commit intogithub:masterfrom
asger-semmle wants to merge 1 commit intogithub:masterfrom
Conversation
ghost
reviewed
Feb 8, 2019
ghost
left a comment
There was a problem hiding this comment.
LGTM.
But I would like a quick performance or DIL check since this query has a brittle performance profile.
Contributor
Author
|
As discussed, we'll go with #920 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix some false positives that were introduced with the recent change to
PropWritein class constructors.