Skip to content

Java: Simplify tests using InlineExpectationsTest#5347

Merged
smowton merged 2 commits intogithub:mainfrom
Marcono1234:marcono1234/simplify-tests
Mar 8, 2021
Merged

Java: Simplify tests using InlineExpectationsTest#5347
smowton merged 2 commits intogithub:mainfrom
Marcono1234:marcono1234/simplify-tests

Conversation

@Marcono1234
Copy link
Contributor

@Marcono1234 Marcono1234 commented Mar 5, 2021

Instead of using value = "y" just use value = "" to not require including the value in the Java test classes

smowton
smowton previously approved these changes Mar 8, 2021
@smowton smowton force-pushed the marcono1234/simplify-tests branch from fce8145 to 6cf15f4 Compare March 8, 2021 11:58
@smowton
Copy link
Contributor

smowton commented Mar 8, 2021

Fixed this to include recent changes

@Marcono1234
Copy link
Contributor Author

Thanks, and sorry that the pull request was based on an outdated main state.

@smowton smowton merged commit f9f143d into github:main Mar 8, 2021
@Marcono1234 Marcono1234 deleted the marcono1234/simplify-tests branch March 8, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants