Add missing java.nio.file.Files methods to FileReadWrite.qll#3820
Merged
aschackmull merged 2 commits intogithub:masterfrom Jul 7, 2020
Merged
Add missing java.nio.file.Files methods to FileReadWrite.qll#3820aschackmull merged 2 commits intogithub:masterfrom
aschackmull merged 2 commits intogithub:masterfrom
Conversation
Contributor
|
LGTM, but could you please autoformat? Otherwise the PR check will fail. |
Contributor
Author
|
Sorry for the delay. Formatted the file now and force pushed (due to the low number of changed files, hope this is alright). |
Contributor
|
There is a zero-width space (U+200B) after |
Contributor
Author
|
Sorry for the trouble and good that you noticed it! I copied it from https://docs.oracle.com/en/java/javase/14/docs/api/index.html (to prevent any typos), but sadly the method names have this |
aschackmull
approved these changes
Jul 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds:
Files.linesFiles.readString