Skip to content

Fix formatting of description in code review instructions and quote handling#104

Merged
aaronpowell merged 1 commit into
github:mainfrom
artemsaveliev:patch-1
Jul 17, 2025
Merged

Fix formatting of description in code review instructions and quote handling#104
aaronpowell merged 1 commit into
github:mainfrom
artemsaveliev:patch-1

Conversation

@artemsaveliev

@artemsaveliev artemsaveliev commented Jul 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • My contribution adds a new instruction, prompt, or chat mode file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, or chat mode with GitHub Copilot.
  • I have run node update-readme.js and verified that README.md is up to date.

Description

Fixes yaml formatting
Updates update-readme.js to handle this correct kind of quote escaping

Type of Contribution

  • New instruction file.
  • New prompt file.
  • New chat mode file.
  • Other (please specify): yaml fix

Additional Notes

By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

Copilot AI review requested due to automatic review settings July 16, 2025 21:59
Copilot AI reviewed Jul 16, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes YAML formatting in the front matter of the Gilfoyle code review instructions file. The change removes unnecessary double quotes around the description field and properly escapes the apostrophe character.

  • Corrected YAML syntax in the front matter description field

Comment thread instructions/gilfoyle-code-review.instructions.md Outdated
---
applyTo: '**'
description: 'Gilfoyle-style code review instructions that channel the sardonic technical supremacy of Silicon Valley\'s most arrogant systems architect.'
description: Gilfoyle-style code review instructions that channel the sardonic technical supremacy of Silicon Valley's most arrogant systems architect.

Copilot AI Jul 16, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description field value should be wrapped in single quotes according to the coding guidelines. It should be: description: 'Gilfoyle-style code review instructions that channel the sardonic technical supremacy of Silicon Valley's most arrogant systems architect.'

Copilot generated this review using guidance from repository custom instructions.

@artemsaveliev artemsaveliev Jul 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect, to escape single quote in a string wrapped by single quotes you need to use two single quotes

updated per .github/copilot-instructions.md

@artemsaveliev
Fix formatting of description in code review instructions
c980cf6 
Fixed handling of quotes in update-readme.js code
@artemsaveliev artemsaveliev changed the title Fix formatting of description in code review instructions Fix formatting of description in code review instructions and quote handling Jul 16, 2025
@aaronpowell aaronpowell merged commit db0d474 into github:main Jul 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@aaronpowell aaronpowell aaronpowell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artemsaveliev @aaronpowell