This repository was archived by the owner on May 9, 2022. It is now read-only.
Use projection attributes for content and provider IDs#8
Merged
chrisd8088 merged 4 commits intovfs-apifrom Mar 15, 2019
Merged
Conversation
Pass our content and provider ID metadata to the Linux interoperability class, which will (in subsequent commits and with a dependency on changes to the libprojfs API) then write and read these IDs as metadata fields stored as file extended attributes.
We pass the content and provider IDs to the libprojfs API function projfs_create_proj_file(), which will store them as extended attributes of the newly created file (pending revisions to the libprojfs API). For directory creation, however, we do not store any metadata attributes, as only files may need to be subsequently hydrated with data, in a second post-projection step which depends on the content ID written during initial the projection step.
We retrieve the content and provider IDs using the new library function projfs_get_attrs(), which (pending revisions to the libprojfs API) searches for and reads any matching extended attributes of the file being hydrated.
b57c222 to
6021d67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a parallel change which should be applied at the same time as github/libprojfs#60, and in conjunction with the revised libprojfs API, should now allow
MirrorProviderto store and retrieve it's dummy content and provider IDs. (And, at least in theory, should allow theGVFSprovider to do the same.)Note that I'm not looking to merge this into
vfs-apiyet; I'd like to do that at the same time as the corresponding libprojfs API changes are merged into master, and as I note in github/libprojfs#60 I'd like to get the test suite working there first. But if you (@kivikakk) could give this a once-over for problems, I'd really appreciate it!