This repository was archived by the owner on Dec 15, 2020. It is now read-only.
Fix null pointer dereference in driver userclient #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IOMemoryDescriptor.map() will return NULL if the length is 0. This can be triggered by sending a report with a single null byte.
|
Looks sensible to me 👍 |
Contributor
Author
|
This fix is included in v0.0.17. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOMemoryDescriptor.map()will returnNULLif the report length is 0. This can be triggered by sending a report with a single null byte. This is fixed by checking the memory descriptor length earlier on. To be doubly sure, we also checking the return value fromreport->map().cc @herrjemand @philipturnbull
fixes #48