V3 Uncommitted Files, CLI and Filewatching (part 2)#5945
Merged
krlvi merged 3 commits intogitbutlerapp:masterfrom Jan 17, 2025
Merged
V3 Uncommitted Files, CLI and Filewatching (part 2)#5945krlvi merged 3 commits intogitbutlerapp:masterfrom
krlvi merged 3 commits intogitbutlerapp:masterfrom
Conversation
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
That way it will provide the needed information.
6 tasks
krlvi
approved these changes
Jan 17, 2025
Member
krlvi
left a comment
There was a problem hiding this comment.
Mostly discussed offline - thanks for this. Im gonna merge this and put together a typescript representation of the return
Collaborator
Author
|
So fast! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new crate for the code that will drive the V3 of the UI design, with the goal of sketching out the API that shows how to deal with uncommited files.
This sketch should also include an idea how to listen to changes to the filesystem to produce events that help maintain the current state.
Follow-up of #5912 .
Tasks
gixfrommainbefore mergingblendgix::*::Change::TypeintoChange::Modificationmaybe+xor-xNotes for the reviewer
but-corebesidesgixthere are no dependencies needed to handle thebut_core::WorktreeChanges..git/indextracking - if it changes while a commit is made, we have to reconcile (or at least assure nothing can go wrong)For later