Skip to content

Update keyring to the latest version (#5751)#5753

Merged
krlvi merged 1 commit intogitbutlerapp:masterfrom
Byron:update-keyring
Dec 13, 2024
Merged

Update keyring to the latest version (#5751)#5753
krlvi merged 1 commit intogitbutlerapp:masterfrom
Byron:update-keyring

Conversation

@Byron
Copy link
Collaborator

@Byron Byron commented Dec 6, 2024 •
edited
Loading

Hopefully this helps with improving WSL2 support, see #5751. It's a quick shot though, I didn't check their changelog.
Also, I couldn't find any bugs reported that would mention WSL.

Tasks

  • upgrade to latest API of keyring (this affects the git-credentials implementation only)
    • Assure git credentials store still works
  • assure the 'normal' credentials store still works (needed cargo features now, it does nothing by default).
  • fix issue with git credentials store credentials being URL encoded when queried (gitoxide issue, which takes url::password() directly even though it's percent-encoded)

Notes for the Reviewer

  • I only tested this on MacOS this time, and would assume it still works on all other platforms as well.

@vercel
Copy link

vercel bot commented Dec 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 0:47am
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 0:47am

@vercel
Copy link

vercel bot commented Dec 6, 2024

@Byron is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the rust Pull requests that update Rust code label Dec 6, 2024
@Byron Byron marked this pull request as ready for review December 6, 2024 07:48
@Byron Byron requested a review from krlvi December 6, 2024 09:31
@Byron Byron mentioned this pull request Dec 8, 2024
Closed
@Byron
Update keyring to the latest version (gitbutlerapp#5751)
27a15f2 
Hopefully this helps with improving WSL2 support.
@Byron Byron requested a review from Caleb-T-Owens December 10, 2024 15:07
@Byron Byron mentioned this pull request Dec 10, 2024
Merged
13 tasks
Caleb-T-Owens
Caleb-T-Owens approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@Caleb-T-Owens Caleb-T-Owens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Byron
Copy link
Collaborator Author

Byron commented Dec 11, 2024

It should be safe to merge, but depending on the plans for the next release, this could wait just like #5722.
Thus, I let @krlvi merge both when good and ready.

@krlvi krlvi merged commit a296279 into gitbutlerapp:master Dec 13, 2024
@Byron Byron deleted the update-keyring branch December 13, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krlvi krlvi krlvi approved these changes

@Caleb-T-Owens Caleb-T-Owens Caleb-T-Owens approved these changes

Assignees

No one assigned

Labels

rust Pull requests that update Rust code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Byron @krlvi @Caleb-T-Owens