fix #1139#1140
Merged
gitbrent merged 2 commits intogitbrent:masterfrom Feb 9, 2023
mikemeerschaert:fix
Merged
Conversation
Owner
|
Thanks @mikemeerschaert Patches need to be against the code src/*.ts files. Files under See other recent pull requests for examples. |
Contributor
Author
|
Sorry about that @gitbrent, I removed the auto-generated files. |
Owner
|
@mikemeerschaert - can you provide a test case demonstrating the issue being patched? |
Contributor
Author
|
bumping for interest. Hitting this exact case in latest. It's a bummer losing individual options per text node, what does this request need for merge? |
Contributor
Author
|
@treystout it looks like this is in the 3.12.0 milestone, so I think we just need to wait for @gitbrent to find the time to release that version. |
Owner
|
Thanks @mikemeerschaert ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1139.
This issue appears to be caused by the
parseTextToLinesroutine when it is grouping teble cells to handle line breaks. There is a comment to flush the line buffer, but it just pushes more lines to the inputLines1 array without resetting the newLine buffer, resulting in the duplication when an array is supplied in the text field without a breakline parameter.