Change "Downloads" header link to "Installation" and link to README#55
Merged
chrisd8088 merged 3 commits intogit-lfs:mainfrom Feb 6, 2023
Merged
Change "Downloads" header link to "Installation" and link to README#55chrisd8088 merged 3 commits intogit-lfs:mainfrom
chrisd8088 merged 3 commits intogit-lfs:mainfrom
Conversation
chrisd8088
reviewed
Feb 4, 2023
Member
chrisd8088
left a comment
There was a problem hiding this comment.
I think it's a good idea to provide a link to the refreshed installation instructions, thank you!
I'm inclined to want to keep some form of link to the available release downloads, though, just because otherwise they are a little obscure (off on the side of the main project page), so I suggest changing the "Downloads" link to a "Releases" one.
If that's acceptable with you, then I'm good with this PR, and thanks again!
Co-authored-by: Chris Darroch <chrisd@apache.org>
Contributor
Author
@chrisd8088 Great point and idea! ✨ I have committed your suggestion. 🙇♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in this pull request, it is currently hard to find installation instructions on the website for an operating system that is not the one that the website is opened on.
I would argue that most users look for "installation" instead of "download" instructions, therefore I think that renaming the header link to "installation" would be it easier discoverable for users.
More over I think that linking to the README installation instructions is more helpful than linking directly to the downloadable release binaries. (The README installation instructions include links to the binaries.)
❗ Note that this pull request assumes that the README pull request is being accepted and merged since it links to the
#installingsection in the README.The current version only includes instructions to install from binaries or source whereas the new proposed version includes all options.
Before
After