script/build-git: update Ubuntu 24.04 APT sources#5889
Merged
chrisd8088 merged 1 commit intogit-lfs:mainfrom Oct 16, 2024
Merged
script/build-git: update Ubuntu 24.04 APT sources#5889chrisd8088 merged 1 commit intogit-lfs:mainfrom
chrisd8088 merged 1 commit intogit-lfs:mainfrom
Conversation
As of Ubuntu 24.04, the primary list of sources for APT moved to the /etc/apt/sources.list.d/ubuntu.sources file instead of the legacy /etc/apt/sources.list file, and was rewritten to make use of the deb822 format, which is based on RFC 822: https://discourse.ubuntu.com/t/ubuntu-24-04-lts-noble-numbat-release-notes/39890#deb822-sources-management https://discourse.ubuntu.com/t/spec-apt-deb822-sources-by-default/29333 https://manpages.ubuntu.com/manpages/noble/man5/sources.list.5.html https://manpages.debian.org/bookworm/dpkg-dev/deb822.5.en.html As GitHub Actions are now migrating their "ubuntu-latest" runners to Ubuntu 24.04, we need to adjust the script our CI jobs use to build custom versions of Git so that it is able to fetch the necessary source packages it requires. We therefore update the script so it checks for the presence of an /etc/apt/sources.list.d/ubuntu.sources file, and if that exists, adds the "deb-src" archive type to the "Types:" lines of the entries in that file; otherwise, the script adds the "deb-src" type to the entries in the /etc/apt/sources.list file as it did previously.
larsxschneider
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Ubuntu 24.04, the primary list of sources for APT moved to the
/etc/apt/sources.list.d/ubuntu.sourcesfile instead of the legacy/etc/apt/sources.listfile, and was rewritten to make use of thedeb822format, which is based on RFC 822. From the Ubuntu 24.04 release notes:As GitHub Actions are now migrating their
ubuntu-latestrunners to Ubuntu 24.04, per actions/runner-images#10636, we need to adjust the script our CI jobs use to build custom versions of Git so that it is able to fetch the necessary source packages it requires.We therefore update the script so it checks for the presence of an
/etc/apt/sources.list.d/ubuntu.sourcesfile, and if that exists, adds thedeb-srcarchive type to theTypes:lines of the entries in that file; otherwise, the script adds thedeb-srctype to the entries in the/etc/apt/sources.listfile as it did previously.A successful run of our
Build with latest GitandBuild with earliest GitCI jobs on anubuntu-24.04runner demonstrates these changes work as expected.