Conversation
This Makefile uses brace expansion ({foo,bar}), which is bash-specific.
To avoid `git config --global ...` in setup catching user configuration file.
|
Thanks for these changes! I think they seem reasonable, on a first look. I was initially going to suggest that we could avoid setting the Then it occurred to me that if we do set Would you be amenable to trying that in this PR? I can push a small commit to your branch, if you're willing to grant me permission to do that; otherwise, would you be able to try a patch like this? --- a/t/Makefile
+++ b/t/Makefile
@@ -46,9 +46,9 @@ test-commands : $(TEST_CMDS)
test : test-commands
$(RM) -r remote test_count{,.lock}
- @bash -c ". ./testenv.sh && setup && cd t && \
+ @ . ./testenv.sh && setup && cd t && \
RM_GIT_LFS_TEST_DIR=no $(PROVE) $(PROVE_EXTRA_ARGS) t-*.sh && \
- shutdown"
+ shutdownAlso. just a note re the CI builds—it appears GitHub Actions have upgraded their default runners to Ubuntu 24.04, and we'll have to adjust one of our build scripts for that change, so for now, just ignore those CI failures. I'll get a patch up to deal with the CI breakage shortly. |
chrisd8088
left a comment
There was a problem hiding this comment.
This looks good!
Thanks again for the contributions.
| @bash -c ". ./testenv.sh && setup && cd t && \ | ||
| @. ./testenv.sh && setup && cd t && \ | ||
| RM_GIT_LFS_TEST_DIR=no $(PROVE) $(PROVE_EXTRA_ARGS) t-*.sh && \ | ||
| shutdown" | ||
| shutdown |
There was a problem hiding this comment.
Thanks so much for adding this change! It's great to be able to take advantage of the fixed shell environment here.
Fix when /bin/sh is not bash, or XDG_CONFIG_HOME is set