Skip to content

release: v3.5.0#5660

Merged
bk2204 merged 1 commit intomainfrom
release-next
Feb 28, 2024
Merged

release: v3.5.0#5660
bk2204 merged 1 commit intomainfrom
release-next

Conversation

@bk2204
Copy link
Member

@bk2204 bk2204 commented Feb 26, 2024

This is an in-progress look at the next release of Git LFS, v3.5.0, which is scheduled for Wednesday, February 28, 2024.

I've attached some builds below for people to use for testing:

git-lfs-darwin-amd64-v3.5.0-pre.zip
git-lfs-darwin-arm64-v3.5.0-pre.zip
git-lfs-freebsd-386-v3.5.0-pre.tar.gz
git-lfs-freebsd-amd64-v3.5.0-pre.tar.gz
git-lfs-linux-386-v3.5.0-pre.tar.gz
git-lfs-linux-amd64-v3.5.0-pre.tar.gz
git-lfs-linux-arm64-v3.5.0-pre.tar.gz
git-lfs-linux-arm-v3.5.0-pre.tar.gz
git-lfs-linux-loong64-v3.5.0-pre.tar.gz
git-lfs-linux-ppc64le-v3.5.0-pre.tar.gz
git-lfs-linux-riscv64-v3.5.0-pre.tar.gz
git-lfs-linux-s390x-v3.5.0-pre.tar.gz
git-lfs-v3.5.0-pre.tar.gz
git-lfs-windows-386-v3.5.0-pre.zip
git-lfs-windows-amd64-v3.5.0-pre.zip
git-lfs-windows-arm64-v3.5.0-pre.zip

In addition, the CI system will produce artifacts for Windows, Linux, and macOS if you prefer to use those; they should be equivalent.

/cc @git-lfs/core
/cc @git-lfs/implementers
/cc @git-lfs/releases

@bk2204 bk2204 added the release label Feb 26, 2024
@bk2204 bk2204 requested a review from a team as a code owner February 26, 2024 20:10
Copy link
Member

@chrisd8088 chrisd8088 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one typo we might want to fix, and a couple of additional folks we might want to thank; otherwise, this looks great!

@ashmckenzie
Copy link

An observation.. the git-lfs-linux-amd64-v3.5.0.tar.gz version is dynamically linked and so won't run on alpine:latest (for example) as-is:

# file git-lfs-3.5.0-pre/git-lfs
git-lfs-3.5.0-pre/git-lfs: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, Go BuildID=6yUzwT69nb_yIpT5QFo4/VcpRhuJbxc4HZktYqqGk/W2nxHh0SJPuvdjp-gCA3/y6FidpeezUj6Btuh9PQs, stripped

vs. 3.4.1:

# file git-lfs-3.4.1/git-lfs
git-lfs-3.4.1/git-lfs: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=vME7dbHSShz0q15IUGMe/UuIpeLL6H1YxP2LAOG4Z/FpibnEC8r9

@ashmckenzie
Copy link

git-lfs-linux-amd64-v3.5.0.tar.gz tests nicely against gitlab.com as confirmed via https://gitlab.com/gitlab-org/git-test/-/jobs/6273154997 🙂👍

I can also confirm that git-lfs-darwin-amd64-v3.5.0-pre.zip works nicely and resolves blocking errors when the server is using the pure SSH-based protocol! 🎉

@bk2204
Copy link
Member Author

bk2204 commented Feb 28, 2024

An observation.. the git-lfs-linux-amd64-v3.5.0.tar.gz version is dynamically linked and so won't run on alpine:latest (for example) as-is:

That's because the v3.5.0-pre binaries are built on my system without CGO_ENABLED=0, whereas CI sets that flag (I just run make release). That's expected, and the CI binaries can be used if you want a statically built binary.

@bk2204 bk2204 merged commit 0757d45 into main Feb 28, 2024
@bk2204 bk2204 deleted the release-next branch February 28, 2024 19:09
@bk2204
Copy link
Member Author

bk2204 commented Feb 28, 2024

Looks like our release failed due to #5662 and also due to Git for Windows 2.44 (which appears to be new in the Actions images today but was not present on Monday) lacking the msgfmt.exe binary, which makes our release builds (and also CI) fail.

Once we find a good solution to finding a new msgfmt binary, we'll try again with a v3.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants