Support using credentials from multiple accounts against the LFS endpoint#554
Support using credentials from multiple accounts against the LFS endpoint#554technoweenie merged 3 commits intogit-lfs:masterfrom
Conversation
…et in the git config Provide the URL path to 'git credential fill' for credential helpers that need the path to return the right credentials Use the objects API URL for credentials so there is a stable path passed to the credential helper for caching
|
Ah, good call. I have a few questions though: Will passing the path to the credential Do you by chance know what path git uses for pushes and pulls? We don't want end users to have to enter their password again for EDIT: Found it. Git doesn't try to do anything intelligent. So, I think this should attempt to use the same path that the remote uses IF In this case, |
|
I think this needs to strip the leading The Username prompt looks correct here: |
|
Added trimming the leading slash, so you get this now: Good idea on re-using the base remote URL, I'll work on that |
…t users don't have to cache the same credentials twice
|
Patch will now use the git remote's credentials if possible. |
|
This looks great. There are a couple more things:
This will likely make it into Git LFS v0.6.0, and a v0.5.5 if another bug fix release is necessary. Thanks for sending this patch! |
|
Thanks again for the patch. I made a private helper and added some shell tests in #561. |
Support credentials from multiple accounts when useHttpPath=true is set in the git config
Provide the URL path to 'git credential fill' for credential helpers that need the path to return the right credentials
Use the objects API URL for credentials so there is a stable path passed to the credential helper for caching