fix(ssh): use /tmp to place control dir on darwin#5223
Merged
bk2204 merged 1 commit intogit-lfs:mainfrom Jan 3, 2023
Merged
Conversation
3edf358 to
5957c47
Compare
bk2204
reviewed
Dec 15, 2022
Member
bk2204
left a comment
There was a problem hiding this comment.
Hey, thanks for the patch. I think there are still a few things we need to address here before going forward.
OpenSSH complains if the control path is too long (>=104)
On Darwin, os.MkdirTemp is too long, use /tmp instead.
ControlPath too long ('/var/folders/v3/5pnzpycs0pzdpytmgfzc7tj80000gn/T/sock-96855798/sock-b677e145501e220cfb5583ba1638a77ffe779df9' >= 104 bytes)
Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
5957c47 to
83fdf8e
Compare
Member
|
Just FYI, most of the Git LFS core team is away on holidays, so it might take a few weeks for this to be reviewed again. |
chrisd8088
approved these changes
Dec 19, 2022
Member
chrisd8088
left a comment
There was a problem hiding this comment.
This looks good to me now, as it seems tightly constrained to just the getControlDir() function. But I know brian was looking at it too, so I'll leave it for him to review as well after the holidays.
Thanks again for the patch!
bk2204
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSH complains if the control path is too long (>=104) On Darwin, os.MkdirTemp is too long, use /tmp instead.
ControlPath too long ('/var/folders/v3/5pnzpycs0pzdpytmgfzc7tj80000gn/T/sock-96855798/sock-b677e145501e220cfb5583ba1638a77ffe779df9' >= 104 bytes)