Update more stale comments relating to object scanning#5164
Merged
chrisd8088 merged 1 commit intogit-lfs:mainfrom Nov 1, 2022
Merged
Update more stale comments relating to object scanning#5164chrisd8088 merged 1 commit intogit-lfs:mainfrom
chrisd8088 merged 1 commit intogit-lfs:mainfrom
Conversation
In commit 201b8ba of PR git-lfs#5163 we updated several comments relating to the change from the use of the "git cat-file --batch" command to an internal ObjectDatabase provided by the github.com/git-lfs/gitobj package. This change was originally made in e3fcde7 of PR git-lfs#3236, but various comments were not updated at the same time. In PR git-lfs#5163 we missed two of those comments, for the NewObjectScanner() and catFileBatchTree() functions, so we update those now as well.
bk2204
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates several stale comments that relate to scanning Git blob objects to find valid Git LFS pointers.
In commit 201b8ba of PR #5163 we updated several comments relating to the change from the use of the
git cat-file --batchcommand to an internalObjectDatabaseprovided by thegithub.com/git-lfs/gitobjpackage. This change was originally made in e3fcde7 of PR #3236, but various comments were not updated at the same time.In PR #5163 we missed two of those comments, for the
NewObjectScanner()andcatFileBatchTree()functions, so we update those now as well.