Change git-lfs migrate import --everything to migrate everything except for special git refs#5045
Conversation
…pt for special git refs.
bk2204
left a comment
There was a problem hiding this comment.
Hey, thanks for the patch, and welcome to Git LFS!
This looks mostly correct. I think there's one change we should make to the code, and some tests, probably in t/t-migrate-import.sh, would also be a good idea.
| } | ||
| prefix := strings.Join(parts[:2], "/") | ||
| switch prefix { | ||
| case "refs/notes", "refs/bisect", "refs/replace": |
There was a problem hiding this comment.
I think we'll also want to include refs/stash here, since we won't want to rewrite stashes.
There was a problem hiding this comment.
Added a small unit test, I'll probably need a bit more time to figure out the how to get the test right in .sh unless people want to give some help on generating examples of excluded refs.
There was a problem hiding this comment.
I think this is probably fine as it stands.
| } | ||
| prefix := strings.Join(parts[:2], "/") | ||
| switch prefix { | ||
| case "refs/notes", "refs/bisect", "refs/replace": |
There was a problem hiding this comment.
I think this is probably fine as it stands.
This PR implements @bk2204 's suggestion in #4810 to only exclude special git refs.