Update INSTALLING.md to fix ubuntu derivative command and allow easy install for some distros#5014
Merged
chrisd8088 merged 4 commits intogit-lfs:mainfrom Jan 4, 2023
ryanhalliday:patch-1
Merged
Update INSTALLING.md to fix ubuntu derivative command and allow easy install for some distros#5014chrisd8088 merged 4 commits intogit-lfs:mainfrom ryanhalliday:patch-1
chrisd8088 merged 4 commits intogit-lfs:mainfrom
ryanhalliday:patch-1
Conversation
- Fix for duplicate `sudo` which causes it to not correctly pass environment variables - Comment for Pop OS and automatic dist selection for Ubuntu based distributions
bk2204
approved these changes
May 19, 2022
Update to use `env` command and wrap to prevent shell env pollution
bk2204
approved these changes
May 20, 2022
Member
bk2204
left a comment
There was a problem hiding this comment.
This looks great. Thanks so much for the patch and for the quick turnaround time in getting this in shape. Since I'll be cutting a release today, we can include this as part of it.
Member
|
It looks like we have some trailing whitespace here that's causing CI to fail. Could you fix that? |
Remove single space after pipe character
Contributor
Author
|
@bk2204 Should be fixed now! Single space after the pipe character. |
bk2204
approved these changes
May 24, 2022
Member
bk2204
left a comment
There was a problem hiding this comment.
Thanks, this looks good. I'll merge it after we've done our release on Wednesday.
|
Member
|
This still looks good to me, so I'm going to merge it once the CI jobs are complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sudowhich causes it to not correctly pass environment variablesIt would be cool if packagecloud could support more distros considering Mint and Pop OS are fairly popular, but that isn't a problem for git-lfs.