git: don't panic on pkt-line without equals #4982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, we can end up with a version of Git that contain a filter-process pkt-line without an equals. (What exactly these contents are is not known.) This causes us to panic when we split, since `v[1]` doesn't exist in the array. Let's fix this by simply ignoring the header if it doesn't contain an equals since we wouldn't care about its value anyway.
chrisd8088
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, we can end up with a version of Git that contain a filter-process pkt-line without an equals. (What exactly these contents are is not known.) This causes us to panic when we split, since
v[1]doesn't exist in the array. Let's fix this by simply ignoring the header if it doesn't contain an equals since we wouldn't care about its value anyway.Fixes #4974