Update and correct several error message strings#4943
Merged
chrisd8088 merged 3 commits intogit-lfs:mainfrom Apr 14, 2022
Merged
Update and correct several error message strings#4943chrisd8088 merged 3 commits intogit-lfs:mainfrom
chrisd8088 merged 3 commits intogit-lfs:mainfrom
Conversation
We convert a message that is output when uninstalling Git hooks back to using a capitalized "Git" project name instead of the lowercase variant. This message was accidentally changed in commit 04abbd8 in PR git-lfs#4846 when making it into a translatable string.
In commit d91980f of PR git-lfs#1822 the GetFilesChanged() function was updated to use "git diff-tree" rather than "git diff". However, the relevant error messages were not updated at the same time, so we do that now.
bk2204
approved these changes
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In commit d91980f of PR #1822 the
GetFilesChanged()function was updated to usegit diff-treerather thangit diff. However, the relevant error messages were not updated at the same time, so we do that now.Also, we convert a message that is output when uninstalling Git hooks back to using a capitalized "Git" project name instead of the lowercase variant. This message was accidentally changed in commit 04abbd8 in PR #4846 when making it into a translatable string.