Closed
Conversation
There are 2 ways to construct LFS urls - from explicit URLs and from the clone URL (which gets info/lfs appended). Previously there were multiple paths where the Endpoint could be constructed in a short-circuit manner which prevents future expansion in common functions. This standardises the Endpoint construction so it always happens via NewEndpoint, and NewEndpointFromCloneURL performs the extra step of appending info/lfs. This has a current effect of supporting SSH urls in all config settings, and not just the remote clone URL as before. But mostly this is to enable future expansion (improved SSH support)
Contributor
Author
|
Code spike served it's purpose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
I started exploring a different approach to #362 based on the assumption that #403 will be merged.