Skip to content

Do not read the configuration from nonexistent file (remove redundant git call)#391

Merged
rubyist merged 1 commit intogit-lfs:masterfrom
bozaro:non-exists-config
Jun 15, 2015
Merged

Do not read the configuration from nonexistent file (remove redundant git call)#391
rubyist merged 1 commit intogit-lfs:masterfrom
bozaro:non-exists-config

Conversation

@bozaro
Copy link
Contributor

@bozaro bozaro commented Jun 15, 2015

No description provided.

@michael-k
Copy link
Contributor

I think this is better placed in ListFromFile itself. Just return an empty string and nil if the file doesn't exist.

@bozaro bozaro force-pushed the non-exists-config branch from de2890d to 8586140 Compare June 15, 2015 10:37
@bozaro
Copy link
Contributor Author

bozaro commented Jun 15, 2015

@michael-k
I move check to ListFromFile :)

@michael-k
Copy link
Contributor

👍

@rubyist rubyist merged commit 8586140 into git-lfs:master Jun 15, 2015
@rubyist
Copy link
Contributor

rubyist commented Jun 15, 2015

👍 Thanks!

@technoweenie technoweenie mentioned this pull request Jun 16, 2015
38 tasks
@bozaro bozaro deleted the non-exists-config branch March 10, 2017 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants